As metals surge and melt values climb, coin collectors face new challenges — from supply shortages to shifting incentives between collecting, investing, and selling.